linux-kernel - Re: [PATCH 01/14] amd64_edac: simplify error type bits extractors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090720175644.GK8168@redhat.com>
Date:	Mon, 20 Jul 2009 13:56:44 -0400
From:	Aristeu Rozanski <aris@...hat.com>
To:	Borislav Petkov <borislav.petkov@....com>
Cc:	mingo@...e.hu, hpa@...or.com, tglx@...utronix.de, norsk5@...oo.com,
	linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 01/14] amd64_edac: simplify error type bits extractors

Hi Borislav,
> -	/* If this was an 'observed' error, early out */
> -	if (ec_pp == K8_NBSL_PP_OBS)
> -		return;		/* We aren't the node involved */
> +
> +	/* Bail early out if this was an 'observed' error */
> +	if (((ec >> 9) & 0x3) == K8_NBSL_PP_OBS)
> +		return;
minor thing:
this patch and others makes me think if it wouldn't be better to have:
	#define PP(x)		(((x) >> 9) & 0x3)
	#define PP_MSG(x)	pp_msgs[PP(x)]
and the same for LL, TT, RRRR.

the rest of the patch series looks good to me

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/