linux-kernel - Re: [PATCH 07/14] mce3: pass mce info to EDAC for decoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090720180446.GB16072@basil.fritz.box>
Date:	Mon, 20 Jul 2009 20:04:46 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Borislav Petkov <borislav.petkov@....com>
Cc:	mingo@...e.hu, hpa@...or.com, tglx@...utronix.de, norsk5@...oo.com,
	aris@...hat.com, linux-kernel@...r.kernel.org, x86@...nel.org,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 07/14] mce3: pass mce info to EDAC for decoding

On Mon, Jul 20, 2009 at 06:12:58PM +0200, Borislav Petkov wrote:
> Use a weakly defined symbol instead of ugly ifdefs.

I'm not sure what you're trying to archive, but if you're
trying to catch corrected MCs you're hooking into the 
wrong function. print_mce is only called for PCC=1.

Also if you're checking for specific banks you
need to check for vendor/cpu model first of course.
In your current implementation e.g. a Intel CPU
would pass some random event into your AMD specific code,
which is probably not intended and might even crash.

It would be probably cleaner if you defined a standard
notifier chain interface.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/