linux-kernel - Re: [PATCH] [usb-serial] fix Ooops on uplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090720234829.1b32b2c0@t61.ukuu.org.uk>
Date:	Mon, 20 Jul 2009 23:48:29 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org, Daniel Mack <daniel@...aq.de>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...hat.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Oliver Neukum <oneukum@...e.de>, linux-usb@...r.kernel.org
Subject: Re: [PATCH] [usb-serial] fix Ooops on uplug

> The reason is that the serial port's resources are freed upon
> disconnect (in serial_hangup()) but the tty device layer is not made
> aware of that. Hence, the close callback will later access the
> resources again.

tty_port_hangup() is part of the hangup path and the physical resources
should not be touched after the hangup completes. It's a good
indication of where the bug might be but its not I suspect the fix as
we now leak the resources.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/