| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090720215841.GJ19257@buzzloop.caiaq.de> Date: Mon, 20 Jul 2009 23:58:41 +0200 From: Daniel Mack <daniel@...aq.de> To: Alan Cox <alan@...ux.intel.com> Cc: linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>, Alan Cox <alan@...hat.com>, Alan Stern <stern@...land.harvard.edu>, Oliver Neukum <oneukum@...e.de>, linux-usb@...r.kernel.org Subject: Re: [PATCH] [usb-serial] fix Ooops on uplug On Mon, Jul 20, 2009 at 11:48:29PM +0100, Alan Cox wrote: > > The reason is that the serial port's resources are freed upon > > disconnect (in serial_hangup()) but the tty device layer is not made > > aware of that. Hence, the close callback will later access the > > resources again. > > tty_port_hangup() is part of the hangup path and the physical resources > should not be touched after the hangup completes. It's a good > indication of where the bug might be but its not I suspect the fix as > we now leak the resources. Depends on how you define the time of removal. The user space connection stays open after the device was removed. And it is closed once the tty layer finds out that it can't write to the hardware anymore. Once you try to bring the tty to life, all resources are freed. At least, this patch fixes a serious oops. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists