linux-kernel - Re: [PATCH] [usb-serial] fix Ooops on uplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090721003239.44ef8e9b@lxorguk.ukuu.org.uk>
Date:	Tue, 21 Jul 2009 00:32:39 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org, Daniel Mack <daniel@...aq.de>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...hat.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Oliver Neukum <oneukum@...e.de>,
	Alan Cox <alan@...ux.intel.com>, linux-usb@...r.kernel.org
Subject: Re: [PATCH] [usb-serial] fix Ooops on uplug

On Mon, 20 Jul 2009 19:51:53 +0200
Daniel Mack <daniel@...aq.de> wrote:

> When an USB serial adapter is disconnected and <Enter> is pressed on a
> connection still open on it (cu, minicom, ...), the kernel crashes.
> 
> The reason is that the serial port's resources are freed upon disconnect
> (in serial_hangup()) but the tty device layer is not made aware of that.
> Hence, the close callback will later access the resources again.

I don't think that is the case. The hangup terminates access to the
resources and replaces the file operations at tty level. The tty
level close called will be the close for the hung up tty ops not the usb
device ops.

hangup() is a termination of access to the bus resources for that tty
handle.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/