linux-kernel - Re: [PATCH] move macsonic's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090721192048.GA10770@pengutronix.de>
Date:	Tue, 21 Jul 2009 21:20:48 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Finn Thain <fthain@...egraphics.com.au>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Jeff Garzik <jgarzik@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] move macsonic's probe function to .devinit.text

Hi Finn,

On Wed, Jul 22, 2009 at 01:14:36AM +1000, Finn Thain wrote:
> On Sat, 11 Jul 2009, Uwe Kleine-K?nig wrote:
>
>> A pointer to mac_sonic_probe is passed to the core via  
>> platform_driver_register and so the function must not disappear when 
>> the .init sections are discarded.  Otherwise (if also having HOTPLUG=y) 
>> unbinding and binding a device to the driver via sysfs will result in 
>> an oops as does a device being registered late.
>
> This patch works for me (tested on a Quadra 630). I still get an oops on  
> rmmod, but that's a separate issue. I'll send a patch for that.
Thanks, I'll add a

	Tested-by: Finn Thain <fthain@...egraphics.com.au>

to the patch description.

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/