linux-kernel - Re: [PATCH] move macsonic's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090721194036.GB10770@pengutronix.de>
Date:	Tue, 21 Jul 2009 21:40:36 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	David Miller <davem@...emloft.net>
Cc:	fthain@...egraphics.com.au, gregkh@...e.de,
	linux-kernel@...r.kernel.org, jgarzik@...hat.com,
	geert@...ux-m68k.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] move macsonic's probe function to .devinit.text

Hi David,

On Tue, Jul 21, 2009 at 12:20:58PM -0700, David Miller wrote:
> From: Finn Thain <fthain@...egraphics.com.au>
> Date: Wed, 22 Jul 2009 01:14:36 +1000 (EST)
>
> > On Sat, 11 Jul 2009, Uwe Kleine-K?nig wrote:
> > 
> >> A pointer to mac_sonic_probe is passed to the core via
> >> platform_driver_register and so the function must not disappear when
> >> the .init sections are discarded.  Otherwise (if also having
> >> HOTPLUG=y) unbinding and binding a device to the driver via sysfs will
> >> result in an oops as does a device being registered late.
> > 
> > This patch works for me (tested on a Quadra 630). I still get an oops
> > on rmmod, but that's a separate issue. I'll send a patch for that.
> 
> Applied, but Uwe _please_ post networking patches to
> netdev@...r.kernel.org so that they get properly logged
> and tracked at:
There are 8 patches in this series that touch drivers/net, only one of
them had a Cc: to netdev.

The diffstat of my series for drivers/net is
 drivers/net/arm/am79c961a.c  |    2 +-
 drivers/net/arm/at91_ether.c |    2 +-
 drivers/net/jazzsonic.c      |    4 ++--
 drivers/net/macsonic.c       |   14 +++++++-------
 drivers/net/meth.c           |    2 +-
 drivers/net/sb1250-mac.c     |    2 +-
 drivers/net/sgiseeq.c        |    2 +-
 drivers/net/xtsonic.c        |    2 +-
 8 files changed, 15 insertions(+), 15 deletions(-)

drivers/net/arm/at91_ether.c got a NACK by David Brownell---he wants the
alternative to be implemented.
drivers/net/arm/am79c961a.c got the Cc to netdev@
You now took drivers/net/macsonic.c.

Should I repost the remaining 5 to netdev@?

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/