linux-kernel - [PATCH] jfs: Fix early release of acl in jfs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A687796.80200@canonical.com>
Date:	Thu, 23 Jul 2009 16:45:42 +0200
From:	Stefan Bader <stefan.bader@...onical.com>
To:	jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org
CC:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
	Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
	Andy Whitcroft <apw@...onical.com>,
	Christophe Dumez <dchris@...il.com>
Subject: [PATCH] jfs: Fix early release of acl in jfs_get_acl

Commit 073aaa1b142461d91f83da66db1184d7c1b1edea "helpers for acl
caching + switch to those" introduced new helper functions for
acl handling but seems to have introduced a regression for jfs as the
acl is released before returning it to the caller, instead of
leaving this for the caller to do.
This causes the acl object to be used after freeing it, leading
to kernel panics in completely different places.

Thanks to Christophe Dumez for reporting and bisecting into this.

Reported-by: Christophe Dumez <dchris@...il.com>
Tested-by: Christophe Dumez <dchris@...il.com>
Signed-off-by: Stefan Bader <stefan.bader@...onical.com>
Acked-by: Andy Whitcroft <apw@...onical.com>
---
  fs/jfs/acl.c |    4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)

View attachment "0001-jfs-Fix-early-release-of-acl-in-jfs_get_acl.patch" of type "text/x-diff" (1434 bytes)