linux-kernel - Re: [PATCH] jfs: Fix early release of acl in jfs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1248365792.29722.3.camel@norville.austin.ibm.com>
Date:	Thu, 23 Jul 2009 11:16:32 -0500
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Stefan Bader <stefan.bader@...onical.com>
Cc:	jfs-discussion@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
	Andy Whitcroft <apw@...onical.com>,
	Christophe Dumez <dchris@...il.com>
Subject: Re: [PATCH] jfs: Fix early release of acl in jfs_get_acl

On Thu, 2009-07-23 at 16:45 +0200, Stefan Bader wrote:
> Commit 073aaa1b142461d91f83da66db1184d7c1b1edea "helpers for acl
> caching + switch to those" introduced new helper functions for
> acl handling but seems to have introduced a regression for jfs as the
> acl is released before returning it to the caller, instead of
> leaving this for the caller to do.
> This causes the acl object to be used after freeing it, leading
> to kernel panics in completely different places.

This looks good.  Thanks much!  I'll get it upstream as soon as
possible.

> Thanks to Christophe Dumez for reporting and bisecting into this.
> 
> Reported-by: Christophe Dumez <dchris@...il.com>
> Tested-by: Christophe Dumez <dchris@...il.com>
> Signed-off-by: Stefan Bader <stefan.bader@...onical.com>
> Acked-by: Andy Whitcroft <apw@...onical.com>
> ---
>   fs/jfs/acl.c |    4 +---
>   1 files changed, 1 insertions(+), 3 deletions(-)

Thanks,
Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/