| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4A6FA17F.20507@pobox.com> Date: Tue, 28 Jul 2009 21:10:23 -0400 From: Jeff Garzik <jgarzik@...ox.com> To: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> CC: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, Dan Carpenter <error27@...il.com>, corbet@....net, eteo@...hat.com Subject: Re: [PATCH] libata: remove superfluous NULL pointer checks Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> > Subject: [PATCH] libata: remove superfluous NULL pointer checks > > host->ports[] always contain pointers to valid port structures since > a "dummy port" structure is used in case if there is no physical port. > > This patch takes care of two entries from Dan's list: > > drivers/ata/sata_sil.c +535 sil_interrupt(13) warning: variable derefenced before check 'ap' > drivers/ata/sata_mv.c +2517 mv_unexpected_intr(6) warning: variable derefenced before check 'ap' > > and of another needless NULL pointer check in pata_octeon_cf.c. > > Reported-by: Dan Carpenter <error27@...il.com> > Cc: corbet@....net > Cc: eteo@...hat.com > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> > --- > drivers/ata/pata_octeon_cf.c | 3 ++- > drivers/ata/sata_mv.c | 2 +- > drivers/ata/sata_sil.c | 2 +- > 3 files changed, 4 insertions(+), 3 deletions(-) applied to #upstream-fixes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists