| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 28 Jul 2009 21:10:37 -0400 From: Jeff Garzik <jgarzik@...ox.com> To: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> CC: linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org, Dan Carpenter <error27@...il.com>, corbet@....net, eteo@...hat.com Subject: Re: [PATCH] libata: add missing NULL pointer check to ata_eh_reset() Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> > Subject: [PATCH] libata: add missing NULL pointer check to ata_eh_reset() > >>>From Dan's list: > > drivers/ata/libata-eh.c +2403 ata_eh_reset(80) warning: variable derefenced before check 'slave' > > Please note that this is _not_ a real bug at the moment since ata_eh_context > structure is embedded into ata_list structure and the code alwas checks for > 'slave' before accessing 'sehc'. > > Anyway lets add missing check and always have a valid 'sehc' pointer (which > makes code easier to understand and prevents introducing some possible bugs > in the future). > > Reported-by: Dan Carpenter <error27@...il.com> > Cc: corbet@....net > Cc: eteo@...hat.com > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> > --- > drivers/ata/libata-eh.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to #upstream-fixes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists