[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0907301246330.4462@axis700.grange>
Date: Thu, 30 Jul 2009 12:56:31 +0200 (CEST)
From: Guennadi Liakhovetski <g.liakhovetski@....de>
To: Ian Molton <ian@...menth.co.uk>
cc: pHilipp Zabel <philipp.zabel@...il.com>,
Paul Mundt <lethal@...ux-sh.org>,
Magnus Damm <magnus.damm@...il.com>,
Mark Brown <broonie@...nsource.wolfsonmicro.com>,
linux-kernel@...r.kernel.org, Pierre Ossman <drzeus@...eus.cx>,
Magnus Damm <damm@...nsource.se>
Subject: Re: MMC: Make the configuration memory resource optional
On Thu, 30 Jul 2009, Ian Molton wrote:
> Ok I've spent some time thinking on this.
>
> There is _no_ clean solution at present and Im not happy with having more than
> one clocking system co-existing in the mmc driver.
>
> I will produce a patch to completely remove all clocking and power control
> from the driver and make it use callbacks in order to achieve this. This will
> leave us with a clean driver that will be simple to adapt to the clock API.
>
> I wont have time to work on it until next week, however, so if anyone wants to
> take a stab at it in the meantime, feel free to do so, and I'll review it next
> week.
While you're at it, please, consider swapping the two lines in
tmio_mmc_probe():
- tmio_mmc_clk_stop(host);
reset(host);
+ tmio_mmc_clk_stop(host);
Otherwise, I think, reset causes problems trying to access the controller
with disabled clock. At least this is needed on SuperH.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists