linux-kernel - Re: MMC: Make the configuration memory resource optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A71F2A5.4060206@mnementh.co.uk>
Date:	Thu, 30 Jul 2009 20:21:09 +0100
From:	Ian Molton <ian@...menth.co.uk>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
CC:	pHilipp Zabel <philipp.zabel@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Magnus Damm <magnus.damm@...il.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, Pierre Ossman <drzeus@...eus.cx>,
	Magnus Damm <damm@...nsource.se>
Subject: Re: MMC: Make the configuration memory resource optional

Guennadi Liakhovetski wrote:

> While you're at it, please, consider swapping the two lines in 
> tmio_mmc_probe():
> 
> -	tmio_mmc_clk_stop(host);
> 	reset(host);
> +	tmio_mmc_clk_stop(host);
> 
> Otherwise, I think, reset causes problems trying to access the controller 
> with disabled clock. At least this is needed on SuperH.

Interesting. I'll see what the result of this is on TMIO - This sequence 
was garnered from the WinCE driver for the chip.

I cant see _why_ this should be a problem, as this disables the card 
clock, not HCLK. Could you debug further in tmio_mmc_clk_stop() please 
and see if reordering only one of the two IO accesses cures this?

Let me know what you find out.

-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/