linux-kernel - Re: [PATCH] Add reboot fixup for SBC-fitPC2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A719CAD.3030508@compulab.co.il>
Date:	Thu, 30 Jul 2009 16:14:21 +0300
From:	Mike Rapoport <mike@...pulab.co.il>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	hpa@...or.com, linux-kernel@...r.kernel.org, denis@...pulab.co.il
Subject: Re: [PATCH] Add reboot fixup for SBC-fitPC2

Hi Andrew,

Andrew Morton wrote:
> On Mon, 20 Jul 2009 18:48:17 +0300
> Mike Rapoport <mike@...pulab.co.il> wrote:
> 
>>> From: Denis Turischev <denis@...pulab.co.il>
>> This patch adds reboot fixup for CompuLab SBC-fitPC2 board.
>>
>> Singned-off-by: Denis Turischev <denis@...pulab.co.il>
>> Signedd-off-by: Mike Rapoport <mike@...pulab.co.il
>>
>> diff -Nru linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c
>> linux-2.6.31-rc3/arch/x86/kernel/reboot.c
>> --- linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c	2009-07-14 04:18:52.000000000
>> +0300
>> +++ linux-2.6.31-rc3/arch/x86/kernel/reboot.c	2009-07-16 14:39:48.000000000 +0300
>> @@ -249,6 +249,15 @@
>>  			DMI_MATCH(DMI_PRODUCT_NAME, "VGN-Z540N"),
>>  		},
>>  	},
>> +	{	/* Handle problems with rebooting on
>> +				CompuLab SBC-FITPC2 board */
>> +		.callback = set_bios_reboot,
>> +		.ident = "CompuLab SBC-FITPC2",
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "CompuLab"),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "SBC-FITPC2"),
>> +		},
>> +	},
>>  	{ }
>>  };
>>
> 
> Neither this patch nor Denis's earlier version contained an adequate
> decription.  We aren't told what these "problems" are, so we're unable
> to judge the appropriateness of patch.
> 
> Both patches were wordwrapped.

Sorry, my bad. Somehow I though my mail client can send patches without wrapping
them :(

> Both patches use an atypical layout style for the comments.


> I fixed up some of these things and merged the patch into my tree, for
> sending to Ingo for 2.6.32.
> 
> Please send a description of the problem which the patch fixes and I
> shall add that to my copy of the changelog.

sbc-fitpc2 board hangs on reboot without this patch. We saw fixups for Dell and
others that set BIOS reboot and that worked for us as well. So, I'd say that
changelog entry should be

--
x86: DMI match for CompuLab SBC-FITPC2 as it needs BIOS reboot.
-- 

Thanks a lot.

> Thanks.
> 

-- 
Sincerely yours,
Mike.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/