linux-kernel - Re: [PATCH] sdio: add CD disable support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090730185044.GH3058@console-pimps.org>
Date:	Thu, 30 Jul 2009 19:50:44 +0100
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Ohad Ben-Cohen <ohad@...cohen.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Philip Langdale <philipl@...rt.org>, ian@...menth.co.uk,
	pierre@...man.eu, linux-kernel@...r.kernel.org,
	linux-embedded@...r.kernel.org, nico@....org,
	nicolas.ferre@....atmel.com, hskinnemoen@...el.com,
	tony@...mide.com, david-b@...bell.net, manuel.lauss@...il.com,
	mirq-l@...per.es, Adrian Hunter <adrian.hunter@...ia.com>,
	Madhusudhan <madhu.cr@...com>
Subject: Re: [PATCH] sdio: add CD disable support

On Thu, Jul 30, 2009 at 06:55:14PM +0300, Ohad Ben-Cohen wrote:
> On Thu, Jul 30, 2009 at 3:45 PM, Matt Fleming<matt@...sole-pimps.org> wrote:
> > Do you have a follow-up patch to make use of this new functionality?
> 
> Well, sort of:
> 
> The patch sets disable_cd for TI wl1271 embedded wlan sdio device on a
> ZOOM2 platform.
> 
> Since the patch is very board/device specific, we first route it via
> internal maintainers, so it is not posted yet.
> 
> It's nothing fancy:
> 
> diff --git a/arch/arm/mach-omap2/mmc-twl4030.c
> b/arch/arm/mach-omap2/mmc-twl4030.c
> index 5b64bf1..caa8b16 100644
> --- a/arch/arm/mach-omap2/mmc-twl4030.c
> +++ b/arch/arm/mach-omap2/mmc-twl4030.c
> @@ -81,6 +81,7 @@ static struct embedded_sdio_data omap_wifi_emb_data = {
>  		.wide_bus       = 1,
>  		.high_power     = 0,
>  		.high_speed     = 0,
> +		.disable_cd	= 1,
>  	},
>  	.funcs  = wifi_func_array,
>  	.num_funcs = 2,

Ah, that's fair enough then. I just wanted to make sure that a patch
that used this functionality was in the pipeline :-)

As David has already said, both comments need fixing up. It is the host
controller driver that decides whether to disable the DAT[3] pull-up,
not the card. If you make those changes then you can add my Acked-by.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/