linux-kernel - Re: [PATCH] sdio: add CD disable support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd5b16740907310410q6860eba1m58e5cf2b771d157b@mail.gmail.com>
Date:	Fri, 31 Jul 2009 14:10:24 +0300
From:	Ohad Ben-Cohen <ohad@...cohen.org>
To:	David Vrabel <david.vrabel@....com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Philip Langdale <philipl@...rt.org>,
	Matt Fleming <matt@...sole-pimps.org>, ian@...menth.co.uk,
	pierre@...man.eu, linux-kernel@...r.kernel.org,
	linux-embedded@...r.kernel.org, nico@....org,
	nicolas.ferre@....atmel.com, hskinnemoen@...el.com,
	tony@...mide.com, david-b@...bell.net, manuel.lauss@...il.com,
	mirq-l@...per.es, Adrian Hunter <adrian.hunter@...ia.com>,
	Madhusudhan <madhu.cr@...com>
Subject: Re: [PATCH] sdio: add CD disable support

Hi David,

Thank you for your comments.

On Thu, Jul 30, 2009 at 3:54 PM, David Vrabel<david.vrabel@....com> wrote:
> Platforms may rely on the card's pull-up and not fit/configure an
> external one.  There may need to be a way for host controller drivers to
>  say this and prevent the disabling of the card's DAT3 pull-up.

Currently the only way to really disable the CD using this patch is by
setting the disable_cd bit on for a specific controller. We are doing so
for a specific controller to which an embedded sdio device is wired,
on certain boards. This is done using the embedded_sdio's .cccr field,
which is used instead of reading the card's cccr.
So as you correctly noted, card has no say here.

> The first sentence of this comment doesn't make sense.

Fixed;

I'll follow-up with a correction of the patch and will appreciate your review.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/