| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Jul 2009 23:21:18 +0200 From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> To: Ingo Molnar <mingo@...hat.com> Cc: linux-kernel@...r.kernel.org, Dan Carpenter <error27@...il.com>, corbet@....net, eteo@...hat.com, Julia Lawall <julia@...u.dk> Subject: [PATCH] x86: remove superfluous NULL pointer check in destroy_irq() From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> Subject: [PATCH] x86: remove superfluous NULL pointer check in destroy_irq() This takes care of the following entry from Dan's list: arch/x86/kernel/apic/io_apic.c +3241 destroy_irq(11) warning: variable derefenced before check 'desc' Reported-by: Dan Carpenter <error27@...il.com> Cc: corbet@....net Cc: eteo@...hat.com Cc: Julia Lawall <julia@...u.dk> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> --- arch/x86/kernel/apic/io_apic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: b/arch/x86/kernel/apic/io_apic.c =================================================================== --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -3238,8 +3238,7 @@ void destroy_irq(unsigned int irq) cfg = desc->chip_data; dynamic_irq_cleanup(irq); /* connect back irq_cfg */ - if (desc) - desc->chip_data = cfg; + desc->chip_data = cfg; free_irte(irq); spin_lock_irqsave(&vector_lock, flags); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists