linux-kernel - [tip:x86/apic] x86: Remove superfluous NULL pointer check in destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-25f6e89bedd29cc49bfa0d55497e91a671b9ae6e@git.kernel.org>
Date:	Sun, 2 Aug 2009 19:41:08 GMT
From:	tip-bot for Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, julia@...u.dk, hpa@...or.com,
	mingo@...hat.com, bzolnier@...il.com, eteo@...hat.com,
	corbet@....net, error27@...il.com, tglx@...utronix.de,
	mingo@...e.hu
Subject: [tip:x86/apic] x86: Remove superfluous NULL pointer check in destroy_irq()

Commit-ID:  25f6e89bedd29cc49bfa0d55497e91a671b9ae6e
Gitweb:     http://git.kernel.org/tip/25f6e89bedd29cc49bfa0d55497e91a671b9ae6e
Author:     Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
AuthorDate: Thu, 30 Jul 2009 23:21:18 +0200
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Sun, 2 Aug 2009 21:37:00 +0200

x86: Remove superfluous NULL pointer check in destroy_irq()

This takes care of the following entry from Dan's list:

  arch/x86/kernel/apic/io_apic.c +3241 destroy_irq(11) warning: variable derefenced before check 'desc'

Reported-by: Dan Carpenter <error27@...il.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc: Jonathan Corbet <corbet@....net>
Cc: Eugene Teo <eteo@...hat.com>
Cc: Julia Lawall <julia@...u.dk>
LKML-Reference: <200907302321.19086.bzolnier@...il.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 arch/x86/kernel/apic/io_apic.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index cf51b0b..7e92a92 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3185,8 +3185,7 @@ void destroy_irq(unsigned int irq)
 	cfg = desc->chip_data;
 	dynamic_irq_cleanup(irq);
 	/* connect back irq_cfg */
-	if (desc)
-		desc->chip_data = cfg;
+	desc->chip_data = cfg;
 
 	free_irte(irq);
 	spin_lock_irqsave(&vector_lock, flags);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/