linux-kernel - Re: [PATCH 1/1] acer-wmi: switch driver to dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200907311356.57529.rjw@sisk.pl>
Date:	Fri, 31 Jul 2009 13:56:56 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Arnaud Faucher <arnaud.faucher@...il.com>
Cc:	Carlos Corbacho <carlos@...angeworlds.co.uk>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Frans Pop <elendil@...net.nl>,
	Manuel Lauss <manuel.lauss@...il.com>,
	Erik Ekman <erik@...o.se>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH 1/1] acer-wmi: switch driver to dev_pm_ops

On Friday 31 July 2009, Arnaud Faucher wrote:
> On Wed, Jul 29, 2009 at 18:53 -0400, Arnaud Faucher wrote :
> > As of today, acer_platform_freeze() does not stop/reset any device, so,
> > I agree with Rafael that for acer-wmi, .thaw() can be skipped. I had
> > also tested this configuration and it was working like the non-patched
> > code.
> > 
> > Carlos, do you think that any acer-specific hardware could be switched
> > off or reset inside acer_platform_freeze() ? If this was the case, we
> > would have to wire .thaw()...
> > 
> 
> Should I send a new patch with only .freeze() and .restore() wired ?

Just for clarification.

If you need .freeze(), then you need .suspend() as well (they can both point
to the same function).  Similarly, if you .restore(), then .resume() is needed
as well.

Otherwise the driver is going to break suspend to RAM (or resume).

Best,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/