linux-kernel - Re: [GIT PULL] Additional x86 fixes for 2.6.31-rc5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0908011501470.3352@localhost.localdomain>
Date:	Sat, 1 Aug 2009 15:04:55 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"H. Peter Anvin" <hpa@...or.com>
cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>
Subject: Re: [GIT PULL] Additional x86 fixes for 2.6.31-rc5

On Sat, 1 Aug 2009, H. Peter Anvin wrote:
> 
> This is clearly better... now the semi-obvious question becomes if there
> is any way we can get compiler support to do better and migrate to that
> as the compiler allows.

Well, even if we had compiler support, we'd have to basically then wait 
forever to make sure everybody has a supported compiler. So I think we're 
better off not worrying too much about that - it's not going to happen any 
time in the near future.

I've now tested my patch, and it seems to result in a working kernel too. 

> In particular, if I remember right the problem with using __thread for 
> percpu was exactly that the current cpuness can change almost anywhere, 
> unless preemption is disabled.

That shouldn't matter. If it uses '%gs', it should all just work 
automatically. But if gcc does something different for thread-local, it's 
basically useless.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/