linux-kernel - RE: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A5FE05C4C76E4C4CAB15D9962B96FC950C7957A892@orsmsx510.amr.corp.intel.com>
Date:	Mon, 3 Aug 2009 10:53:27 -0700
From:	"Othman, Ossama" <ossama.othman@...el.com>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3

>> >It is recommended to separate definition,
>> >and assignment.
>> >So this should look like this:
>> >	struct memrar_allocator *allocator;
>> >	allocator = 0;
>> Okay, I'll fix that, too.  Should this go into Documentation/CodingStyle,
>too?
>
>I don't agree with that at all, neither does a lot of the kernel source.
>
>Automatic structs with initializers:
>$ grep -rP --include=*.c "^\s+struct\s+\w+\s*\*\s*\w+\s*=\s*\w+\s*;" * | wc
>-l
>9498
>
>I think it should be struct memrar_allocator *allocator = NULL;

Got it.  I've already started changing all zero pointer initializations to NULL instead.  I'll also leave the declaration and initialization on the same line for now.

Thanks again!
-Ossama
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/