linux-kernel - Re: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090803193131.7b25e6c1@lxorguk.ukuu.org.uk>
Date:	Mon, 3 Aug 2009 19:31:31 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Othman, Ossama" <ossama.othman@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Moorestown RAR Handler driver, MRST 2.6.31-rc3

> This guideline doesn't appear in Documentation/CodingStyle.  Should it?

Possibly - the thing is there are several cases where its used
deliberately the other way around.

>> >> +	struct memrar_allocator *allocator = 0;
> >
> >It is recommended to separate definition,
> >and assignment.
> >So this should look like this:
> >
> >	struct memrar_allocator *allocator;
> >
> >	allocator = 0;
> 
> Okay, I'll fix that, too.  Should this go into Documentation/CodingStyle, too?

This is nonsense to put it politely. It's a pointer so it should be =
NULL but the formatting is just fine. It's not in the coding style
because its bunkum 8)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/