[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87zlaeiakr.fsf@basil.nowhere.org>
Date: Wed, 05 Aug 2009 16:45:08 +0200
From: Andi Kleen <andi@...stfloor.org>
To: Amerigo Wang <amwang@...hat.com>
Cc: linux-kernel@...r.kernel.org, tony.luck@...el.com,
linux-ia64@...r.kernel.org, Neil Horman <nhorman@...hat.com>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
akpm@...ux-foundation.org, Ingo Molnar <mingo@...e.hu>,
Anton Vorontsov <avorontsov@...mvista.com>
Subject: Re: [Patch 1/7] x86: add CONFIG_KEXEC_AUTO_RESERVE
Amerigo Wang <amwang@...hat.com> writes:
> Introduce a new config option KEXEC_AUTO_RESERVE for x86.
The description of the feature belongs in the changelog.
I like the basic idea, but:
> +config KEXEC_AUTO_RESERVE
> + bool "automatically reserve memory for kexec kernel"
> + depends on KEXEC
> + default y
> + ---help---
> + Automatically reserve memory for a kexec kernel, so that you don't
> + need to specify numbers for the "crashkernel=X@Y" boot option,
> + instead you can use "crashkernel=auto".
> + On x86, 128M is reserved.
The obvious problem is the hardcoded 128MB (and 128MB is very large
for a crash kernel anyways)
More useful would seem a crashkernel=size@...o
-Andi
--
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists