linux-kernel - Re: [PATCH 2/3] libata: Bind the Linux device tree to the ACPI device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a01a16b50908052354h28522bafja255c4fcac9a2ea8@mail.gmail.com>
Date:	Thu, 6 Aug 2009 08:54:31 +0200
From:	Håkon Løvdal <hlovdal@...il.com>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-scsi@...r.kernel.org, James.Bottomley@...senpartnership.com,
	shaohua.li@...el.com, linux-ide@...r.kernel.org
Subject: Re: [PATCH 2/3] libata: Bind the Linux device tree to the ACPI device 
	tree

2009/7/13 Matthew Garrett <mjg@...hat.com>:
> +               if (!sata_pmp_attached(ap))
> +                       adr = SATA_ADR(ap->port_no, NO_PORT_MULT);
> +               else
> +                       adr = SATA_ADR(ap->port_no, dev->link->pmp);

Maybe I am missing something, but wouldn't it be more natural to write this as

        if (sata_pmp_attached(ap))
                adr = SATA_ADR(ap->port_no, dev->link->pmp);
        else
                adr = SATA_ADR(ap->port_no, NO_PORT_MULT);

BR Håkon Løvdal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/