linux-kernel - Re: [PATCH 2/3] libata: Bind the Linux device tree to the ACPI device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090806145125.GB3181@srcf.ucam.org>
Date:	Thu, 6 Aug 2009 15:51:25 +0100
From:	Matthew Garrett <mjg@...hat.com>
To:	Håkon Løvdal <hlovdal@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-scsi@...r.kernel.org, James.Bottomley@...senpartnership.com,
	shaohua.li@...el.com, linux-ide@...r.kernel.org
Subject: Re: [PATCH 2/3] libata: Bind the Linux device tree to the ACPI
	device tree

On Thu, Aug 06, 2009 at 08:54:31AM +0200, Håkon Løvdal wrote:
> Maybe I am missing something, but wouldn't it be more natural to write this as
> 
>         if (sata_pmp_attached(ap))
>                 adr = SATA_ADR(ap->port_no, dev->link->pmp);
>         else
>                 adr = SATA_ADR(ap->port_no, NO_PORT_MULT);

Heh, yes. That would also work.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/