linux-kernel - Re: [PATCH 1/2] chrdev: implement __[un]register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A7A90AB.3050407@suse.de>
Date:	Thu, 06 Aug 2009 17:13:31 +0900
From:	Tejun Heo <teheo@...e.de>
To:	Greg KH <greg@...ah.com>
Cc:	Al Viro <viro@....linux.org.uk>, Takashi Iwai <tiwai@...e.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	cguthrie@...driva.org
Subject: Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev()

Tejun Heo wrote:
> Hello,
> 
> Greg KH wrote:
>> Yes the names are confusing, the whole api needs a rework to make it
>> easier to understand :(
> 
> For now, I'll open code it then but it would be really nice to clean
> the names up.

Crap, there's a difference.  For [un]register_chrdev() the chrdev
layer keeps track of cdev while using cdev_alloc/add/del() directly
requires the caller to keep track of the pointer.  Also, it's a bit of
pain to open code the whole thing.

For now, it looks like adding the __ prefixed versions seems to be the
proper solution.  It's strange to provide the helper interface only
for full minor acquisitions anyway.  Let's do naming cleanup later.
How does that sound?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/