linux-kernel - Re: [PATCH 1/2] chrdev: implement __[un]register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090806195848.GA29827@kroah.com>
Date:	Thu, 6 Aug 2009 12:58:48 -0700
From:	Greg KH <greg@...ah.com>
To:	Tejun Heo <teheo@...e.de>
Cc:	Al Viro <viro@....linux.org.uk>, Takashi Iwai <tiwai@...e.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	cguthrie@...driva.org
Subject: Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev()

On Thu, Aug 06, 2009 at 05:13:31PM +0900, Tejun Heo wrote:
> Tejun Heo wrote:
> > Hello,
> > 
> > Greg KH wrote:
> >> Yes the names are confusing, the whole api needs a rework to make it
> >> easier to understand :(
> > 
> > For now, I'll open code it then but it would be really nice to clean
> > the names up.
> 
> Crap, there's a difference.  For [un]register_chrdev() the chrdev
> layer keeps track of cdev while using cdev_alloc/add/del() directly
> requires the caller to keep track of the pointer.  Also, it's a bit of
> pain to open code the whole thing.
> 
> For now, it looks like adding the __ prefixed versions seems to be the
> proper solution.  It's strange to provide the helper interface only
> for full minor acquisitions anyway.  Let's do naming cleanup later.
> How does that sound?

Well, what's the odds that I can get you to do cleanup now?  :)

Sure, I'll take this, only if Takashi wants the other stuff that depends
on it.  Let me know.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/