linux-kernel - Re: [PATCH] markup_oops: Use modinfo to avoid confusion with underscored module names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A7AF77C.3070204@pardus.org.tr>
Date:	Thu, 06 Aug 2009 18:32:12 +0300
From:	Ozan Çağlayan <ozan@...dus.org.tr>
To:	Arjan van de Ven <arjan@...radead.org>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] markup_oops: Use modinfo to avoid confusion with underscored
 module names

Arjan van de Ven wrote:
> On Thu,  6 Aug 2009 15:21:55 +0300
> Ozan Çağlayan <ozan@...dus.org.tr> wrote:
>
>   
>> When EIP is at a module having an underscore in its name, the current
>> code fails to find it because the module filenames has '-' instead of
>> '_'.
>>
>> Use modinfo to correctly get the full path to the module.
>>
>> Signed-off-by: Ozan Çağlayan <ozan@...dus.org.tr>
>>     
>
> I like it, it's simple.
> I don't mind about the module-init-tools dependency, everyone will have
> that already.
>   

BTW, note that the old code was searching for *.ko files in
dirname($vmlinux_name). Replacing it by modprobe will eventually always
search for the modules in /lib/modules/KVER/.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/