linux-kernel - Re: iwlwifi (4965) regression since 2.6.30

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090806224110.GJ3382@ics.muni.cz>
Date:	Fri, 7 Aug 2009 00:41:10 +0200
From:	Lukas Hejtmanek <xhejtman@....muni.cz>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	reinette chatre <reinette.chatre@...el.com>,
	Johannes Berg <johannes@...solutions.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: iwlwifi (4965) regression since 2.6.30

On Thu, Aug 06, 2009 at 10:22:44AM -0300, Henrique de Moraes Holschuh wrote:
> 1. .config from both of you

attached.
 
> 2. the output of "grep . /sys/bus/platform/devices/thinkpad_acpi/hotkey_*";

grep . /sys/bus/platform/devices/thinkpad_acpi/hotkey_*
/sys/bus/platform/devices/thinkpad_acpi/hotkey_all_mask:0x00ffffff
/sys/bus/platform/devices/thinkpad_acpi/hotkey_bios_enabled:0
/sys/bus/platform/devices/thinkpad_acpi/hotkey_bios_mask:0x0000080c
/sys/bus/platform/devices/thinkpad_acpi/hotkey_enable:1
/sys/bus/platform/devices/thinkpad_acpi/hotkey_mask:0x008c7fff
/sys/bus/platform/devices/thinkpad_acpi/hotkey_poll_freq:10
/sys/bus/platform/devices/thinkpad_acpi/hotkey_radio_sw:1
/sys/bus/platform/devices/thinkpad_acpi/hotkey_recommended_mask:0x008c7fff
/sys/bus/platform/devices/thinkpad_acpi/hotkey_report_mode:1
/sys/bus/platform/devices/thinkpad_acpi/hotkey_source_mask:0x00000000
 

> 3. the keymap of the thinkpad-acpi input device.  On Debian, "lsinput and
> input-kbd" from package "input-utils" can be used to locate the correct
> input device and dump its keymap.  Other distros have similar input-device
> utilities, I think.

lsinput
/dev/input/event0
   bustype : BUS_HOST
   vendor  : 0x0
   product : 0x1
   version : 0
   name    : "Power Button"
   phys    : "LNXPWRBN/button/input0"
   bits ev : EV_SYN EV_KEY

/dev/input/event1
   bustype : BUS_HOST
   vendor  : 0x0
   product : 0x5
   version : 0
   name    : "Lid Switch"
   phys    : "PNP0C0D/button/input0"
   bits ev : EV_SYN EV_SW

/dev/input/event2
   bustype : BUS_HOST
   vendor  : 0x0
   product : 0x3
   version : 0
   name    : "Sleep Button"
   phys    : "PNP0C0E/button/input0"
   bits ev : EV_SYN EV_KEY

/dev/input/event3
   bustype : BUS_I8042
   vendor  : 0x1
   product : 0x1
   version : 43860
   name    : "AT Translated Set 2 keyboard"
   phys    : "isa0060/serio0/input0"
   bits ev : EV_SYN EV_KEY EV_MSC EV_LED EV_REP

/dev/input/event4
   bustype : BUS_I8042
   vendor  : 0x2
   product : 0x7
   version : 33201
   name    : "SynPS/2 Synaptics TouchPad"
   phys    : "isa0060/serio1/input0"
   bits ev : EV_SYN EV_KEY EV_ABS

/dev/input/event5
   bustype : BUS_I8042
   vendor  : 0x2
   product : 0xa
   version : 0
   name    : "TPPS/2 IBM TrackPoint"
   phys    : "synaptics-pt/serio0/input0"
   bits ev : EV_SYN EV_KEY EV_REL

/dev/input/event6
   bustype : BUS_HOST
   vendor  : 0x0
   product : 0x6
   version : 0
   name    : "Video Bus"
   phys    : "/video/input0"
   bits ev : EV_SYN EV_KEY

/dev/input/event7
   bustype : BUS_HOST
   vendor  : 0x17aa
   product : 0x5054
   version : 16641
   name    : "ThinkPad Extra Buttons"
   phys    : "thinkpad_acpi/input0"
   bits ev : EV_SYN EV_KEY EV_MSC EV_SW

I guess, input-kbd is needed for the last one:

input-kbd 7
/dev/input/event7
   bustype : BUS_HOST
   vendor  : 0x17aa
   product : 0x5054
   version : 16641
   name    : "ThinkPad Extra Buttons"
   phys    : "thinkpad_acpi/input0"
   bits ev : EV_SYN EV_KEY EV_MSC EV_SW

map: 32 keys, size: 32/64
0x0000 = 466  # KEY_FN_F1
0x0001 = 152  # KEY_SCREENLOCK
0x0002 = 236  # KEY_BATTERY
0x0003 = 142  # KEY_SLEEP
0x0004 = 238  # KEY_WLAN
0x0005 = 471  # KEY_FN_F6
0x0006 = 227  # KEY_SWITCHVIDEOMODE
0x0007 = 192  # KEY_F22
0x0008 = 194  # KEY_F24
0x0009 = 475  # KEY_FN_F10
0x000a = 476  # KEY_FN_F11
0x000b = 205  # KEY_SUSPEND
0x000c = 240  # KEY_UNKNOWN
0x000d = 240  # KEY_UNKNOWN
0x000e = 240  # KEY_UNKNOWN
0x000f = 225  # KEY_BRIGHTNESSUP
0x0010 = 224  # KEY_BRIGHTNESSDOWN
0x0011 = 228  # KEY_KBDILLUMTOGGLE
0x0012 = 240  # KEY_UNKNOWN
0x0013 = 372  # KEY_ZOOM
0x0014 = 115  # KEY_VOLUMEUP
0x0015 = 114  # KEY_VOLUMEDOWN
0x0016 = 113  # KEY_MIN_INTERESTING
0x0017 = 148  # KEY_PROG1
0x0018 = 240  # KEY_UNKNOWN
0x0019 = 240  # KEY_UNKNOWN
0x001a = 240  # KEY_UNKNOWN
0x001b = 240  # KEY_UNKNOWN
0x001c = 240  # KEY_UNKNOWN
0x001d = 240  # KEY_UNKNOWN
0x001e = 240  # KEY_UNKNOWN
0x001f = 240  # KEY_UNKNOWN

 
> I guess 2.6.31 has the new rfkill code, and this likely enabled rfkill-input
> or something.
> 
> If you *really* want to make sure fn+f5 will never give you surprises, you
> either:
> 
> 1. switch bit 4 off from /sys/bus/platform/devices/thinkpad_acpi/hotkey_mask
> 
> or
> 
> 2. program scancode 4 on the thinkpad-acpi input device to something that is
> not KEY_WLAN, KEY_BLUETOOTH, etc.
> 
> 
> ACPI events for fn+f5 will be generated *only* on the deprecated, outdated
> /proc/acpi/event interface.  hotkey_mask gets rid of those too.

well, at least, I would like behavior where Fn+F5 does not do rfkill silently
(I guess in kernel?). I would prefer an event or just a key code. This is not
possible any more?

-- 
Lukáš Hejtmánek

View attachment "config" of type "text/plain" (63796 bytes)