lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Aug 2009 21:05:54 -0700 From: Greg KH <greg@...ah.com> To: Tejun Heo <teheo@...e.de> Cc: Al Viro <viro@....linux.org.uk>, Takashi Iwai <tiwai@...e.de>, Linux Kernel <linux-kernel@...r.kernel.org>, cguthrie@...driva.org Subject: Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev() On Fri, Aug 07, 2009 at 11:34:52AM +0900, Tejun Heo wrote: > Hello, Greg. > > Greg KH wrote: > >> For now, it looks like adding the __ prefixed versions seems to be the > >> proper solution. It's strange to provide the helper interface only > >> for full minor acquisitions anyway. Let's do naming cleanup later. > >> How does that sound? > > > > Well, what's the odds that I can get you to do cleanup now? :) > > I'd be happy to but whether cleaning it up would be benefitial or not > is a bit unclear. We have 214 users of [un]register_chrdev_region() > and 118 users of [un]register_chrdev(). So, renaming the latter to, > say, create/destroy_chrdev() and make it take @baseminor and > @nr_minors should do it but I'm not quite sure whether it would worth > touching all those files. Maybe it's better left as a mess like the > page allocation functions? Yeah, I guess it's easier to leave it alone for now. If I ever get bored, I'll work on cleaning them up :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists