linux-kernel - Re: [patch 2/2] Add a driver for the Winbond WPCD376I Consumer IR hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200908100939.54718.bjorn.helgaas@hp.com>
Date:	Mon, 10 Aug 2009 09:39:53 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	david@...deman.nu
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	jbarnes@...tuousgeek.org, akpm@...ux-foundation.org,
	randy.dunlap@...cle.com
Subject: Re: [patch 2/2] Add a driver for the Winbond WPCD376I Consumer IR hardware

On Sunday 09 August 2009 03:56:47 am david@...deman.nu wrote:
> --- linux-2.6.orig/drivers/input/misc/Kconfig	2009-07-25 21:18:57.000000000 +0200
> +++ linux-2.6/drivers/input/misc/Kconfig	2009-08-07 21:45:41.000000000 +0200
> @@ -222,6 +222,22 @@
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called sgi_btns.
>  
> +config INPUT_WINBOND_CIR
> +	tristate "Winbond IR remote control"
> +	depends on X86 && ACPI

This should depend on PNP, not ACPI.

> +#define WBCIR_ACPI_NAME	"Winbond CIR"

You might remove "ACPI" from "WBCIR_ACPI_NAME," since it has nothing
to do with ACPI.

Otherwise, looks good to me.

Bjorn


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/