linux-kernel - Re: [PATCH] [16/19] HWPOISON: Enable .remove_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090812085727.GE28848@basil.fritz.box>
Date:	Wed, 12 Aug 2009 10:57:27 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Nick Piggin <npiggin@...e.de>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>, tytso@....edu,
	hch@...radead.org, mfasheh@...e.com, aia21@...tab.net,
	hugh.dickins@...cali.co.uk, swhiteho@...hat.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, fengguang.wu@...el.com,
	Satoshi OSHIMA <satoshi.oshima.fk@...achi.com>,
	Taketoshi Sakuraba <taketoshi.sakuraba.hc@...achi.com>
Subject: Re: [PATCH] [16/19] HWPOISON: Enable .remove_error_page for
	migration aware file systems

On Wed, Aug 12, 2009 at 10:46:13AM +0200, Nick Piggin wrote:
> On Wed, Aug 12, 2009 at 10:23:31AM +0200, Andi Kleen wrote:
> > > page corruption, IMO, because by definition they should be able to
> > > tolerate panic. But if they do not know about this change to -EIO
> > > semantics, then it is quite possible to cause problems.
> > 
> > There's no change really. You already have this problem with
> > any metadata error, which can cause similar trouble.
> > If the application handles those correctly it will also 
> > handle hwpoison correctly.
> 
> What do you mean metadata error?

e.g. when there's an write error on the indirect block or any
other fs metadata. This can also cause you to lose data. The error 
reporting also works through the address space like with hwpoison,
so it only gets reported once.

I'm not really against fixing that (make the error more sticky
as Fengguang puts it), but I don't think it needs to be mixed
with hwpoison.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/