linux-kernel - Re: [RFC patch] init default dma_ops to prepare intel_iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250101222.29180.139.camel@macbook.infradead.org>
Date:	Wed, 12 Aug 2009 19:20:22 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Fenghua Yu <fenghua.yu@...el.com>
Cc:	Luming Yu <luming.yu@...il.com>,
	"Luck, Tony" <tony.luck@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC patch] init default dma_ops to prepare intel_iommu_init
 failure

On Wed, 2009-08-12 at 11:17 -0700, Fenghua Yu wrote:
> 
> >  void __init pci_swiotlb_init(void)
> >  {
> > -     if (!iommu_detected || iommu_pass_through) {
> 
> This check can not be removed. Otherwise, swiotlb_dma_ops will always override
> previous dma_ops value.
> 
> I think you can change this check to something like:
>         if (!dma_ops || iommu_pass_through) {
> With this change, checking iommu_detected is unnecesary because checking dma_ops
> covers it.

Hm, that iommu_pass_through should go away anyway. See commit 19943b0e3.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/