linux-kernel - [RFC patch] clean up swiotlb check in intel_iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <3877989d0908122011n27589ff8wfc6d6b50912496c6@mail.gmail.com>
Date:	Thu, 13 Aug 2009 11:11:27 +0800
From:	Luming Yu <luming.yu@...il.com>
To:	David Woodhouse <dwmw2@...radead.org>,
	"Yu, Fenghua" <fenghua.yu@...el.com>,
	"Luck, Tony" <tony.luck@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	Andrew Morton <akpm@...ux-foundation.org>
Subject: [RFC patch] clean up swiotlb check in intel_iommu_init

Hi there,

Since swiotlb is an fall back option that might have
initialized. We don't need to stop intel_iommu_init
because of swiotlb..

Please review. If make sense, please apply.

**The patch is enclosed in text attachment*
**Using web client to send the patch* *
**below is for review, please apply attached  patch*/

Thanks,
Luming

Signed-off-by: Yu Luming <luming.yu@...el.com>

 intel-iommu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
index 2314ad7..246acb9 100644
--- a/drivers/pci/intel-iommu.c
+++ b/drivers/pci/intel-iommu.c
@@ -3194,7 +3194,7 @@ int __init intel_iommu_init(void)
 	 * Check the need for DMA-remapping initialization now.
 	 * Above initialization will also be used by Interrupt-remapping.
 	 */
-	if (no_iommu || (swiotlb && !iommu_pass_through) || dmar_disabled)
+	if (no_iommu || dmar_disabled)
 		return -ENODEV;

 	iommu_init_mempool();

Download attachment "6" of type "application/octet-stream" (496 bytes)