linux-kernel - Re: [RFC patch] clean up swiotlb check in intel_iommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090813122456P.fujita.tomonori@lab.ntt.co.jp>
Date:	Thu, 13 Aug 2009 12:25:39 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	luming.yu@...il.com
Cc:	dwmw2@...radead.org, fenghua.yu@...el.com, tony.luck@...el.com,
	linux-kernel@...r.kernel.org, fujita.tomonori@....ntt.co.jp,
	akpm@...ux-foundation.org
Subject: Re: [RFC patch] clean up swiotlb check in intel_iommu_init

On Thu, 13 Aug 2009 11:11:27 +0800
Luming Yu <luming.yu@...il.com> wrote:

> Hi there,
> 
> Since swiotlb is an fall back option that might have
> initialized. We don't need to stop intel_iommu_init
> because of swiotlb..

I think that this doesn't work on X86; breaks "soft" boot option.


> Please review. If make sense, please apply.
> 
> **The patch is enclosed in text attachment*
> **Using web client to send the patch* *
> **below is for review, please apply attached  patch*/
> 
> Thanks,
> Luming
> 
> Signed-off-by: Yu Luming <luming.yu@...el.com>
> 
>  intel-iommu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
> index 2314ad7..246acb9 100644
> --- a/drivers/pci/intel-iommu.c
> +++ b/drivers/pci/intel-iommu.c
> @@ -3194,7 +3194,7 @@ int __init intel_iommu_init(void)
>  	 * Check the need for DMA-remapping initialization now.
>  	 * Above initialization will also be used by Interrupt-remapping.
>  	 */
> -	if (no_iommu || (swiotlb && !iommu_pass_through) || dmar_disabled)
> +	if (no_iommu || dmar_disabled)
>  		return -ENODEV;
> 
>  	iommu_init_mempool();
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/