linux-kernel - Re: [PATCH] icom: bit and/or confusion?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090814155004.GA10977@suse.de>
Date:	Fri, 14 Aug 2009 08:50:04 -0700
From:	Greg KH <gregkh@...e.de>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] icom: bit and/or confusion?

On Fri, Aug 14, 2009 at 02:02:34PM +0200, Roel Kluin wrote:
> Previously, if any bit other than CMD_SND_BREAK was set, CMD_SND_BREAK
> was not unset.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> I think meant was: If CMD_SND_BREAK is set, unset it. Correct?
> 
> // vi drivers/serial/icom.h +137
> #define CMD_SND_BREAK                0x04
> 
> diff --git a/drivers/serial/icom.c b/drivers/serial/icom.c
> index cd1b6a4..060f4e3 100644
> --- a/drivers/serial/icom.c
> +++ b/drivers/serial/icom.c
> @@ -617,7 +617,7 @@ static void shutdown(struct icom_port *icom_port)
>  	 * disable break condition
>  	 */
>  	cmdReg = readb(&icom_port->dram->CmdReg);
> -	if ((cmdReg | CMD_SND_BREAK) == CMD_SND_BREAK) {
> +	if (cmdReg & CMD_SND_BREAK) {

This change is the exact same thing, right?  How is the original
incorrect here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/