linux-kernel - Re: [PATCH] x86, mce: therm_throt: don't log redundant normality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090816152613.GB17313@elte.hu>
Date:	Sun, 16 Aug 2009 17:26:13 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Hugh Dickins <hugh.dickins@...cali.co.uk>
Cc:	Dmitry Torokhov <dtor@...l.ru>, "H. Peter Anvin" <hpa@...or.com>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, mce: therm_throt: don't log redundant normality


* Hugh Dickins <hugh.dickins@...cali.co.uk> wrote:

> Hi Dmitry,
> 
> I'm delighted to find your 
> 0d01f31439c1e4d602bf9fdc924ab66f407f5e38 "x86, mce: therm_throt - 
> change when we print messages" in rc6: thank you.
> 
> I too had been annoyed by "critical" CPU1 Temperature/speed normal 
> messages, with no indication that anything had been abnormal: 
> after resume on a Fujitsu-Siemens Esprimo Mobile (whereas startup 
> decided the Duo's CPU0 Thermal monitoring would be handled by SMI 
> not by MCE).
> 
> I hadn't reported it yet, because I couldn't quite work out what 
> to do about it: your patch looks good, so long as someone else 
> doesn't have a machine which jumps between throttled and 
> unthrottled too quickly.
> 
> But could we add one more thing on top of your patch?  Though it 
> no longer keeps announcing "I am normal", can we please also get 
> rid of the accompanying "Machine check events logged" message too? 
> If the non-event isn't worth showing (I agree that it isn't), then 
> I think it's not worth logging either.

Yeah, makes sense - i've queued it up, thanks Hugh!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/