linux-kernel - [tip:x86/urgent] x86, mce: therm_throt: Don't log redundant normality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-4e5c25d405e18a2f279ca2bfc855508ec3a0186b@git.kernel.org>
Date:	Sun, 16 Aug 2009 15:27:45 GMT
From:	tip-bot for Hugh Dickins <hugh.dickins@...cali.co.uk>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	andi@...stfloor.org, seto.hidetoshi@...fujitsu.com, dtor@...l.ru,
	tglx@...utronix.de, hugh.dickins@...cali.co.uk, mingo@...e.hu
Subject: [tip:x86/urgent] x86, mce: therm_throt: Don't log redundant normality

Commit-ID:  4e5c25d405e18a2f279ca2bfc855508ec3a0186b
Gitweb:     http://git.kernel.org/tip/4e5c25d405e18a2f279ca2bfc855508ec3a0186b
Author:     Hugh Dickins <hugh.dickins@...cali.co.uk>
AuthorDate: Sun, 16 Aug 2009 15:54:37 +0100
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Sun, 16 Aug 2009 17:25:41 +0200

x86, mce: therm_throt: Don't log redundant normality

0d01f31439c1e4d602bf9fdc924ab66f407f5e38 "x86, mce: therm_throt
- change when we print messages" removed redundant
announcements of "Temperature/speed normal".

They're not worth logging and remove their accompanying
"Machine check events logged" messages as well from the
console.

Signed-off-by: Hugh Dickins <hugh.dickins@...cali.co.uk>
Cc: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc: Andi Kleen <andi@...stfloor.org>
Cc: Dmitry Torokhov <dtor@...l.ru>
LKML-Reference: <Pine.LNX.4.64.0908161544100.7929@...ter.anvils>
Signed-off-by: Ingo Molnar <mingo@...e.hu>


---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index 8bc64cf..5957a93 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -116,11 +116,14 @@ static int therm_throt_process(int curr)
 		       cpu, __get_cpu_var(thermal_throttle_count));
 
 		add_taint(TAINT_MACHINE_CHECK);
-	} else if (was_throttled) {
+		return 1;
+	}
+	if (was_throttled) {
 		printk(KERN_INFO "CPU%d: Temperature/speed normal\n", cpu);
+		return 1;
 	}
 
-	return 1;
+	return 0;
 }
 
 #ifdef CONFIG_SYSFS
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/