linux-kernel - Re: [PATCH 5/5] [WATCHDOG] Add support for WM831x watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090816162755.GA14971@sirena.org.uk>
Date:	Sun, 16 Aug 2009 17:27:55 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Wim Van Sebroeck <wim@...ana.be>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] [WATCHDOG] Add support for WM831x watchdog

On Sun, Aug 16, 2009 at 03:28:12PM +0200, Wim Van Sebroeck wrote:

> > +#define WM831X_WDOG_PRIMACT_WIDTH                    2  /* WDOG_PRIMACT - [5:4] */

> These lines exceed 80 characters. Is there any reason why we can't reduce the spacing between the name and the value?

> Just let me know how we will proceed on my second question. I can then add this to the linux-2.6-watchdog-next tree.

The register definitions are automatically generated using the chip
design information using a tool which I'm not the only user for.  It
simplifies maintinance to keep the output code as-is since it allows
easier comparison with future devices with the same or similar IP in
them.  If anything were done I'd remove the comments.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/