linux-kernel - Re: [PATCH 5/5] [WATCHDOG] Add support for WM831x watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 16 Aug 2009 15:28:12 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] [WATCHDOG] Add support for WM831x watchdog

Hi Mark,

> The WM831x series of devices provide a watchdog with configurable
> behaviour on timer expiry.
> 
> Currently this driver support refreshes via a register or GPIO line and
> autonomous refreshes from a hardware source (eg, a clock).
> 
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> Cc: Wim Van Sebroeck <wim@...ana.be>

the driver is OK. Just 2 small remarks:
> +static struct watchdog_info ident = {
> +	.options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE,
> +	.identity = "WM831x Watchdog",
> +};

this can be static const struct in the future (need to do a clean-up on that).

> +#define WM831X_WDOG_SECACT_MASK                 0x0300  /* WDOG_SECACT - [9:8] */
> +#define WM831X_WDOG_SECACT_SHIFT                     8  /* WDOG_SECACT - [9:8] */
> +#define WM831X_WDOG_SECACT_WIDTH                     2  /* WDOG_SECACT - [9:8] */
> +#define WM831X_WDOG_PRIMACT_MASK                0x0030  /* WDOG_PRIMACT - [5:4] */
> +#define WM831X_WDOG_PRIMACT_SHIFT                    4  /* WDOG_PRIMACT - [5:4] */
> +#define WM831X_WDOG_PRIMACT_WIDTH                    2  /* WDOG_PRIMACT - [5:4] */

These lines exceed 80 characters. Is there any reason why we can't reduce the spacing between the name and the value?

Just let me know how we will proceed on my second question. I can then add this to the linux-2.6-watchdog-next tree.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/