linux-kernel - Re: [PATCH 0/3] Generic sysfs support for ACPI ALS and other ALS devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250497963.5351.33.camel@rzhang-dt>
Date:	Mon, 17 Aug 2009 16:32:43 +0800
From:	Zhang Rui <rui.zhang@...el.com>
To:	Pavel Machek <pavel@....cz>
Cc:	linux-acpi <linux-acpi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Len Brown <lenb@...nel.org>,
	Richard Purdie <rpurdie@...ys.net>,
	Matthew Garrett <mjg59@...f.ucam.org>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH 0/3] Generic sysfs support for ACPI ALS and other ALS
	devices

On Thu, 2009-08-06 at 17:52 +0800, Pavel Machek wrote:
> Hi!
> 
> > > Yes, so just export
> > > 
> > > ALS exports
> > > 1. the current ambient light illuminance
> > > 2. the current mapped ambient light illuminance
> > > 
> > In fact, only one attribute is enough.
> 
> Good. (I thought you would want to export the 1) too, mainly for debugging).
> 
> > The ALS driver can query the current illuminance, parse the mapping and
> > only export the display luminance adjustment values to user space.
> 
> > then user space just needs to
> > 1. set a brightness level as the base point
> > 2. get the display adjustment value and calculate a proper brightness
> > level at any time.
> > 
> > this is easier, but it makes me feel that this doesn't look like an
> > _ALS_ device any more.
> > We still should export some ALS properties to user space, shouldn't
> > we?
> 
> Why? Just because ACPI specs is ugly does not mean we should make
> Linux ugly, too. Please just use suggestion above.
> 
> > Could you please look at the documentation about ALS sysfs class in the
> > patch I sent out just now, and comment on that one please? thanks!
> 
> I did. The interface is too ugly to live.

Hi, Pavel,

I tried to convert the ALS sysfs I/F to two attributes only, i.e.
illuminance and adjustment.
But I found several potential problems.
1. the illuminance to display adjustment mappings can not be convert to
a brightness level smoothly.
for example,
	illuminance	adjustment
1	600		70
2	900		100
3	1500		120
when the current illuminance is not one of the values listed in the
mappings, e.g. 750, the ALS driver don't have enough knowledge to get
the proper display adjustment, especially that a proper display
adjustment would be easy to select a proper brightness level.
We'd better leave this to user space, which is more flexible.
2. I don't know if there will be laptops exporting buggy mappings that
needs to be overridden some day, but the current sysfs I/F is easy for
expanding.
what do you think?

thanks,
rui



> 								Pavel
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/