linux-kernel - Re: [PATCH 2/7] kfifo: move out spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090817094842.1d97f841@lxorguk.ukuu.org.uk>
Date:	Mon, 17 Aug 2009 09:48:42 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Stefani Seibold <stefani@...bold.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Andi Kleen <andi@...stfloor.org>,
	Amerigo Wang <xiyou.wangcong@...il.com>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 2/7] kfifo: move out spinlock

I simply pasted randomly from the regexp output. The __ semantic for the
less sanity checking/unlocked/non synchronizing version of an API is all
over the kernel. Not suprisingly as it seems to be a Linusism looking at
some of the old patch sets.

> > And remember: its very hard to fix existing API documentation and
books.
> > It's doubly dangerous (and IMHO a complete no-no) to change the API of an
> > interface if you don't change it such that old code will not reliably get
> > a compile time failure.
> 
> The patchet will cause unmigrated code to fail to build, won't it?

Yes but it won't fix the API docs.

So I still disagree with you. Adding _locked to the API end doesn't solve
any problems

You asked about mutexes but is get_locked() mutex locked, semaphore
locked, spinlocked, rwlocked ? So it doesn't do what you say.

What it does do is make the code more verbose, wider, more likely to go
over 80 columns and more typing.

Anyway I've made my point. I still think you are wrong on this one Andrew
but I think we have to simply continue to disagree.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/