linux-kernel - Re: [PATCH 2/7] kfifo: move out spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090817095349.4cf8d3c5@lxorguk.ukuu.org.uk>
Date:	Mon, 17 Aug 2009 09:53:49 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Andi Kleen <andi@...stfloor.org>,
	Amerigo Wang <xiyou.wangcong@...il.com>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 2/7] kfifo: move out spinlock

> And the spinlock is in most cases useless, because the API works fine if
> only one reader and one writer is using the fifo. This is the common
> case.

That is one good argument for fixing the naming. The USB serial code
probably can be persuaded to use the  single reader/writer assumption as
well.

> If you like it is very easy to add a compatibility layer, which restores
> the old function names. But for what, only for very few users who
> depends on it? This will only waste the name space.

Ooh the tragedy, we are short many things but namespace strangely is not
one of them. Especially when the names all start kfifo_ and __kfifo_, a
namespace much in demand by other code.

I'd rather have the old names, or the new names than some kind of gunge
middle layer of both. Either choice is better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/