linux-kernel - Re: [patch] x86 CPU detection for RDC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A899A1D.8060808@zytor.com>
Date:	Mon, 17 Aug 2009 10:57:49 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Mark Kelly <mark@...feros.com>
CC:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Florian Fainelli <florian@...nwrt.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [patch] x86 CPU detection for RDC

On 08/15/2009 08:35 PM, Mark Kelly wrote:
> diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
> index 4e242f9..9906064 100644
> --- a/arch/x86/kernel/cpu/Makefile
> +++ b/arch/x86/kernel/cpu/Makefile
> @@ -22,6 +22,7 @@ obj-$(CONFIG_CPU_SUP_CYRIX_32)		+= cyrix.o
>  obj-$(CONFIG_CPU_SUP_CENTAUR)		+= centaur.o
>  obj-$(CONFIG_CPU_SUP_TRANSMETA_32)	+= transmeta.o
>  obj-$(CONFIG_CPU_SUP_UMC_32)		+= umc.o
> +obj-$(CONFIG_X86_RDC321X)		+= rdc.o
> 
>  obj-$(CONFIG_X86_MCE)	+= mcheck/
>  obj-$(CONFIG_MTRR)	+= mtrr/

I don't see this defined anywhere.  Where it is defined, it needs to
depend on or select CONFIG_PCI, since the detection code you're
proposing is using unguarded PCI references.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/