[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090817180825.GA5558@elte.hu>
Date: Mon, 17 Aug 2009 20:08:25 +0200
From: Ingo Molnar <mingo@...e.hu>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: Mark Kelly <mark@...feros.com>, linux-kernel@...r.kernel.org,
Florian Fainelli <florian@...nwrt.org>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [patch] x86 CPU detection for RDC
* H. Peter Anvin <hpa@...or.com> wrote:
> On 08/15/2009 08:35 PM, Mark Kelly wrote:
> > diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
> > index 4e242f9..9906064 100644
> > --- a/arch/x86/kernel/cpu/Makefile
> > +++ b/arch/x86/kernel/cpu/Makefile
> > @@ -22,6 +22,7 @@ obj-$(CONFIG_CPU_SUP_CYRIX_32) += cyrix.o
> > obj-$(CONFIG_CPU_SUP_CENTAUR) += centaur.o
> > obj-$(CONFIG_CPU_SUP_TRANSMETA_32) += transmeta.o
> > obj-$(CONFIG_CPU_SUP_UMC_32) += umc.o
> > +obj-$(CONFIG_X86_RDC321X) += rdc.o
> >
> > obj-$(CONFIG_X86_MCE) += mcheck/
> > obj-$(CONFIG_MTRR) += mtrr/
>
> I don't see this defined anywhere. Where it is defined, it needs
> to depend on or select CONFIG_PCI, since the detection code
> you're proposing is using unguarded PCI references.
X86_RDC321X already exists in arch/x86/Kconfig. It should probably
grow a 'depends on PCI' rline or so.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists