linux-kernel - Re: [PATCH 07/12] add ftrace_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0908172004531.25890@gandalf.stny.rr.com>
Date:	Mon, 17 Aug 2009 20:06:24 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
cc:	Jason Baron <jbaron@...hat.com>, linux-kernel@...r.kernel.org,
	mingo@...e.hu, laijs@...fujitsu.com, peterz@...radead.org,
	mathieu.desnoyers@...ymtl.ca, jiayingz@...gle.com,
	mbligh@...gle.com, lizf@...fujitsu.com
Subject: Re: [PATCH 07/12] add ftrace_event_call void * 'data' field


On Tue, 18 Aug 2009, Frederic Weisbecker wrote:
> > > > @@ -568,7 +568,7 @@ static void ftrace_raw_event_##call(proto)				\
> > > >  		trace_nowake_buffer_unlock_commit(event, irq_flags, pc); \
> > > >  }									\
> > > >  									\
> > > > -static int ftrace_raw_reg_event_##call(void)				\
> > > > +static int ftrace_raw_reg_event_##call(void *ptr)			\
> > > 
> > > 
> > > Shouldn't it have a __used attribute here, or something?
> > 
> > Do function parameters need that? There's lots of places where the 
> > parameter of a function is not used by a function itself.
> > 
> > -- Steve
> 
> 
> No actually, I thought gcc would warn, but it didn't :-)

Yeah, that is the right thing too. Because functions can be passed as 
parameters (like this one) and every "stub function" we have will then 
need this attribute. It is OK to ignore parameters of functions without 
telling gcc that you plan on ignoring them.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/