linux-kernel - Re: [patch 2/3] flex_array: fix flex_array_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250554007.10725.22008.camel@nimitz>
Date:	Mon, 17 Aug 2009 17:06:46 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 2/3] flex_array: fix flex_array_free_parts comment

On Mon, 2009-08-17 at 16:46 -0700, David Rientjes wrote:
> flex_array_free_parts() does not take `src' or `element_nr' formals, so
> remove their respective comments.
> 
> Cc: Dave Hansen <dave@...ux.vnet.ibm.com>
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  lib/flex_array.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/flex_array.c b/lib/flex_array.c
> --- a/lib/flex_array.c
> +++ b/lib/flex_array.c
> @@ -122,9 +122,6 @@ static int fa_element_to_part_nr(struct flex_array *fa, int element_nr)
> 
>  /**
>   * flex_array_free_parts - just free the second-level pages
> - * @src:	address of data to copy into the array
> - * @element_nr:	index of the position in which to insert
> - * 		the new element.
>   *
>   * This is to be used in cases where the base 'struct flex_array'
>   * has been statically allocated and should not be free.

Looks great to me.

Signed-off-by: Dave Hansen <dave@...ux.vnet.ibm.com>

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/