linux-kernel - Re: [patch 3/3] flex_array: declare parts member to have incomplete type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1250554043.10725.22015.camel@nimitz>
Date:	Mon, 17 Aug 2009 17:07:23 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 3/3] flex_array: declare parts member to have
 incomplete type

On Mon, 2009-08-17 at 16:46 -0700, David Rientjes wrote:
> The `parts' member of struct flex_array should evaluate to an incomplete
> type so that sizeof() cannot be used and C99 does not require the
> zero-length specification.
> 
> Cc: Dave Hansen <dave@...ux.vnet.ibm.com>
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> ---
>  include/linux/flex_array.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/flex_array.h b/include/linux/flex_array.h
> --- a/include/linux/flex_array.h
> +++ b/include/linux/flex_array.h
> @@ -21,7 +21,7 @@ struct flex_array {
>  		struct {
>  			int element_size;
>  			int total_nr_elements;
> -			struct flex_array_part *parts[0];
> +			struct flex_array_part *parts[];
>  		};
>  		/*
>  		 * This little trick makes sure that

That's a good little trick.  I don't see any downside to it. 

Signed-off-by: Dave Hansen <dave@...ux.vnet.ibm.com>

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/