[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9b2b86520908180623i4e7ce5cv9a4cd6b1704a0e5f@mail.gmail.com>
Date: Tue, 18 Aug 2009 14:23:29 +0100
From: Alan Jenkins <sourcejedi.lkml@...glemail.com>
To: Marcel Holtmann <marcel@...tmann.org>
Cc: Mario Limonciello <mario_limonciello@...l.com>,
linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
cezary.jackiewicz@...il.com
Subject: Re: [PATCH 3/3] Drop platform sysfs support
On 8/18/09, Marcel Holtmann <marcel@...tmann.org> wrote:
> Hi Alan,
>> In practice I suspect it makes no difference that the rfkill and
>> backlight devices are exported as virtual devices with no physical
>> parent. I just don't think it's "right" :-).
>
> it actually does make a difference for hardware detection. We wanna have
> them hanging of the compal platform device.
Ok. I wasn't sure that userspace was allowed to rely on that, but I
re-read Documentation/ABI/testing/sysfs-devices and I see now that it
can be allowed.
Some of these issues with the compal-laptop work may come from copying
dell-laptop. dell-laptop is the only driver which creates rfkill
devices without a parent device. In fact, it doesn't even create a
platform device :-).
I'll try sending a patch or two to clean up dell-laptop. I don't have
the hardware but it should be pretty mechanical, almost a copy+paste
job from a "good" driver.
Thanks
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists