[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4A8AE97E.9050604@dell.com>
Date: Tue, 18 Aug 2009 12:48:46 -0500
From: Mario Limonciello <mario_limonciello@...l.com>
To: Alan Jenkins <sourcejedi.lkml@...glemail.com>
CC: Marcel Holtmann <marcel@...tmann.org>, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org, cezary.jackiewicz@...il.com
Subject: Re: [PATCH 3/3] Drop platform sysfs support
Hi Alan:
Alan Jenkins wrote:
>
> Ok. I wasn't sure that userspace was allowed to rely on that, but I
> re-read Documentation/ABI/testing/sysfs-devices and I see now that it
> can be allowed.
>
> Some of these issues with the compal-laptop work may come from copying
> dell-laptop. dell-laptop is the only driver which creates rfkill
> devices without a parent device. In fact, it doesn't even create a
> platform device :-).
>
> I'll try sending a patch or two to clean up dell-laptop. I don't have
> the hardware but it should be pretty mechanical, almost a copy+paste
> job from a "good" driver.
>
>
Yeah, a lot of the source for the design issues here were from copying
bits out of dell-laptop. I've made adjustments to this third patch to
only drop the sysfs attributes but still create the platform device.
--
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@...l.com
View attachment "03_drop_sysfs_stuff.diff" of type "text/x-patch" (4828 bytes)
Download attachment "signature.asc" of type "application/pgp-signature" (261 bytes)
Powered by blists - more mailing lists